Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define dependencies for Python package #76

Open
6 tasks
berombau opened this issue Sep 9, 2022 · 2 comments
Open
6 tasks

Define dependencies for Python package #76

berombau opened this issue Sep 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@berombau
Copy link
Member

berombau commented Sep 9, 2022

If we want to submit our package to PyPi, we need to define the requirements in a requirements.txt or in pyproject.toml.

Right now we only have 1 conda environment.yaml with everything: build-dependencies, cudatools, direct dependencies, jupyterlab, dev dependencies, test dependencies...

Conda-based plugins in napari are however supported and is also the future direction of napari packaging. But we want to support both PyPi and conda for now.

  • define minimal dependencies to run napari plugin
  • ensure pip install -e . still works
  • also install Hydra and CLI
  • document GPU installation with PyTorch
  • support [testing] (CI tooling, pytest...) and [dev] (testing + jupyterlab...)
  • edit GitHub Actions to build and publish to PyPI with Twine
@berombau berombau added the enhancement New feature or request label Sep 9, 2022
@lopollar
Copy link
Contributor

@ArneDefauw , is this fixed now?
At least for windows, right?

@ArneDefauw
Copy link
Collaborator

I think we still need to define minimal dependencies, if we want to publish to Pypi. I.e. dev dependencies, jupyterlab should not be in this minimal dependencies file.
I don't know if we want to implement all the features described above by @berombau .

Minimal would be to have

  • define minimal dependencies to run napari plugin
  • ensure pip install -e . still works
  • document GPU installation with PyTorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants