You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But the accidentalValue should not be greater than 2. If it is, then it should be another note name. Thus I think the root of the issue is in the way the intervals are calculated, particularly, how it finds the note that is some interval away from another note (from scale tonic in our case).
The text was updated successfully, but these errors were encountered:
eagor
changed the title
Note accidental might be 'undefined' sometimes
Note accidental gets 'undefined' sometimes (accidentalValue() > 3)
Apr 20, 2016
eagor
changed the title
Note accidental gets 'undefined' sometimes (accidentalValue() > 3)
Note accidental gets 'undefined' sometimes (accidentalValue() > 2)
Apr 20, 2016
I suspect this is a result of Note#accidental()
But the accidentalValue should not be greater than 2. If it is, then it should be another note name. Thus I think the root of the issue is in the way the intervals are calculated, particularly, how it finds the note that is some interval away from another note (from scale tonic in our case).
The text was updated successfully, but these errors were encountered: