Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue after reaching Approve or Deny #8

Open
raylenmargono opened this issue Apr 9, 2015 · 6 comments
Open

Issue after reaching Approve or Deny #8

raylenmargono opened this issue Apr 9, 2015 · 6 comments
Labels

Comments

@raylenmargono
Copy link

Hi,

After after clicking on Approve on the page after login, nothing happens. I also tried debugging the uberKit and i found out that the method:

  • (BOOL) webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request navigationType:(UIWebViewNavigationType)navigationType
    {

never gets called. What could be the issue?

11121322_10205533839237987_907312213_n

@sachinkesiraju
Copy link
Owner

Hey @margono13901, Thanks for reaching out! What redirect URI are you using? Also, make sure that the redirect URI you're using is exactly the same as the one you have on Uber Developers.
This looks like it could also be an issue on my side so I'm looking into it.
Thanks,
Sachin

@raylenmargono
Copy link
Author

Hi Sachin!

The redirect uri is correct. I'm certain that it is an issue with the
webview delegate methods. Also did you take into account the redirect
protocol after the Facebook login? It directs to a blank page. Thank you

On Friday, April 10, 2015, Sachin Kesiraju [email protected] wrote:

Hey @margono13901 https://github.com/margono13901, what redirect URI
are you using? Also, make sure that the redirect URI you're using is
exactly the same as the one you have on Uber Developers.
This looks like it could also be an issue on my side so I'm looking into
it.
Thanks,
Sachin


Reply to this email directly or view it on GitHub
#8 (comment)
.

@sachinkesiraju
Copy link
Owner

Hi Raylen,

You're right, it does seem like there's an issue on the web view's delegate methods. I may take some time to fix this (kinda busy at the moment) but I can replace the oauth through web view with safari (that worked fine in a previous commit) soon.
Also, feel free to PR if you find a solution to this.
Thanks,
Sachin

@raylenmargono
Copy link
Author

Hi Sachin,

That would be a great alternative. If you could replace that with safari
that would be great. Could you notifiy me when you have? As for when you
get everything up and running I would like to be notified with that as
well. Great kit!

Thanks
Raylen

On Friday, April 10, 2015, Sachin Kesiraju [email protected] wrote:

Hi Raylen,

You're right, it does seem like there's an issue on the web view's
delegate methods. I may take some time to fix this (kinda busy at the
moment) but I can replace the oauth through web view with safari (that
worked fine in a previous commit) soon.
Also, feel free to PR if you find a solution to this.
Thanks,
Sachin


Reply to this email directly or view it on GitHub
#8 (comment)
.

@dserkin
Copy link

dserkin commented Apr 29, 2015

I was able to complete oauth process completely. But it seems like web view related behavior is broken completely. So basically i used your code only to finish very first step to access auth code. Then I requested token and scopes manually.

Anyway thank you for developing it!

@sachinkesiraju
Copy link
Owner

Hey @dserkin,
If you don't mind, could you share the code that you used to get the oauth working. There definitely seems to be an issue and I'd love to see your working solution.
Thanks,
Sachin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants