Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Sablier-powered ERC-20 contract #1031

Open
PaulRBerg opened this issue Sep 2, 2024 · 7 comments
Open

Create a Sablier-powered ERC-20 contract #1031

PaulRBerg opened this issue Sep 2, 2024 · 7 comments
Assignees
@smol-ninja
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

As discussed in https://github.com/sablier-labs/company-discussions/discussions/62#discussioncomment-10509265.

@smol-ninja's idea:

function _mintwithVesting(address account, uint256 value, params) internal {
    _mint(address(this), value);
    _approve(LOCKUP_LINEAR, value);
    // few parameters will be hard coded
    LOCKUP_LINEAR.createWithDurations(params);
}
@PaulRBerg PaulRBerg added type: feature New feature or request. effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Sep 2, 2024
@smol-ninja smol-ninja self-assigned this Sep 4, 2024
@PaulRBerg
Copy link
Member Author

Once this is implemented, an adjacent task would be to attempt to get this ERC-20 template integrated in OpenZeppelin.

@PaulRBerg
Copy link
Member Author

PaulRBerg commented Oct 22, 2024 •
edited
Loading

Just checking we're still on track to include this in Lockup v2.0.0?

It's an important feature.

@smol-ninja
Copy link
Member

Yes.

@smol-ninja smol-ninja removed their assignment Oct 31, 2024
@smol-ninja smol-ninja self-assigned this Nov 16, 2024
@PaulRBerg
Copy link
Member Author

Unfortunately, we won't have time to include this in v2.0.0 but maybe we can discuss it during the weekend in-person!

@andreivladbrg
Copy link
Member

Agree, no time for this

@smol-ninja
Copy link
Member

Can we please hold onto this until we freeze the code? If I can't get it delivered by next Friday, we can omit it from v2.0.0.

@PaulRBerg
Copy link
Member Author

Yeah, sure. Let's discuss this during the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @andreivladbrg