You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Repo
---
- Readme
Great top level readme, very detailed.
- Personal opinion about repo name
Sandbox sounds like we're gonna play
with core Sablier code. Intuitively I'm expecting this to be a thin
front layer, that gives me easy access to the contract with a simple UI,
so I can focus on developing the
contract itself, not the frontend integrations of it.
If the goal is to have more examples there, I would consider
renaming it.
- Minimize the devenv pain by completing the readmes, like [Vercel](https://github.com/vercel/next.js/tree/canary/examples)
Able to come in, see the readme, have 2, max 3 commands to
copy paste in the terminal without having to think and have it running.
It's a great first gauge, especially in open source.
Don't have the dev figuring out if the example uses this or that package
manager, or have to read through the readme in details.
Examples
---
- Beyond showcasing different libraries, also showcase different use cases.
For example, a subscription use case where stream can be cancelled
at any time.
Ask community to contribute their use cases.
I would lock in on one library, and use it across all other examples.
People will figure out how to use it with their stack if they see their
use cases covered.
- Read example
Showcasing how to read from Sablier using Subgraphs
- End-to-end example
Create simple stream, fetch it's state from Graph, cancel it.
- Existing examples
Links to Sablier app: Would be nice to have a preview of the stream or
directly the url to the stream in the Sablier app so we could actually
verify what was created
From the headless tab:
Buttons don't work unless you have approved. Having them all disabled/greyed
out until it's approved should help.
Could be useful to have all the lifecycle actions of a stream, create,
transfer, revoke, …
UI
---
- Dynamic
We had some difficulties editing Segment exponent, we either didn't
understand how it works or something was off
Having issues adding or deleting numbers, sometimes
SDK
---
- Would love to see hooks
- Built-in caching, thinking something like `react-query`
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Dumped it from email, needs triaging @razgraf @gavriliumircea:
Beta Was this translation helpful? Give feedback.
All reactions