Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add tests for MigrationGrader #74

Open
tansaku opened this issue Feb 19, 2016 · 6 comments · May be fixed by #126
Open

Add tests for MigrationGrader #74

tansaku opened this issue Feb 19, 2016 · 6 comments · May be fixed by #126
Assignees

Comments

@tansaku
Copy link
Contributor

tansaku commented Feb 19, 2016

MigrationGrader is in the code base but not tested

@tansaku tansaku self-assigned this Feb 19, 2016
@tansaku
Copy link
Contributor Author

tansaku commented Feb 19, 2016

I set up a test of the new grader for doing a migration grading, but we get this error

#<Graders::AutoGrader::NoSuchGraderError: Can't find grading strategy for MigrationGrader>

which I've encountered before - which is related to previous issue I mentioned in #63

I can quick fix that by adding the following temporarily to lib/autograder.rb:44

    require_relative 'graders/migration_grader/migration_grader.rb'

but that leads to this error:

expected PutResultException, got #<ArgumentError: Unable to find submission file "submissions/506af89a6181960fc69f47f1fbc8d708/performance-assignment/2016-02-19-12-20-54"> with backtrace:
        # ./lib/graders/migration_grader/migration_grader.rb:19:in `initialize'

which makes me think that the migration grader is still operating exactly at the old grader. So we would need to change the operation of the migration grader to work with wherever the submissions are now being inserted ...

@tansaku
Copy link
Contributor Author

tansaku commented Feb 19, 2016

note of course that setting up this way still falls foul of #70 ...

@tansaku
Copy link
Contributor Author

tansaku commented Feb 19, 2016

So the existing MigrationGrader is looking for an archive file submitted by the student, however the new grader is providing a directory ...

@tansaku
Copy link
Contributor Author

tansaku commented Feb 19, 2016

the old migration grader unpacks the archive with a TempArchiveFile class that's no longer in the repo ...

@zhangaaron
Copy link
Contributor

Not too aware of the migration grader, this was a low priority grader that was not updated with the autograder rehauling last summer. We aren't using it in Professor Fox's offering of the class, are you aware of any interest in using it in the online class?

@tansaku
Copy link
Contributor Author

tansaku commented Mar 2, 2016

hi @zhangaaron it's being used in the online class (and has been every cycle for the last 3 years), and one of your fellow TAs recently asked for access to add two more homeworks to the Berkeley SPOC - not sure if this was one of them ...

@tansaku tansaku linked a pull request Jan 21, 2019 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants