Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

acceptance unit test grader has data being added in a migration #127

Open
tansaku opened this issue Mar 15, 2019 · 0 comments · May be fixed by #128
Open

acceptance unit test grader has data being added in a migration #127

tansaku opened this issue Mar 15, 2019 · 0 comments · May be fixed by #128

Comments

@tansaku
Copy link
Contributor

tansaku commented Mar 15, 2019

Adding data to the database in migrations is not recommended - see https://thoughtbot.com/blog/data-migrations-in-rails

This can cause problems if students copy feature files from the previous assignment which are double checking the numbers of entries in the database. That itself may be bad practice, but two wrongs don't make a right :-)

@tansaku tansaku linked a pull request Mar 15, 2019 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant