Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search feature unresponsive after setting an empty list #321

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Mar 29, 2024

What was happening

  • To replicate it:
    1. Open the dropdown and click on the Search input
    2. Checked we can type there and sort the list
    3. Click on Remove All
    4. Open the dropdown and click on the Search input
    5. Checked that it is disabled as expected since the options list has no options
    6. Click on Fill
    7. Open the dropdown and click on the Search input
    8. Checked that it is incorrectly disabled

#318_Issue

After the fix

  • The fix was on the method focusElementOnOpen()
  • To replicate it:
    1. Open the dropdown and click on the Search input
    2. Checked we can type there and sort the list
    3. Click on Remove All
    4. Open the dropdown and click on the Search input
    5. Checked that it is disabled as expected since the options list has no options
    6. Click on Fill
    7. Open the dropdown and click on the Search input
    8. Checked we can type there and sort the list

#318_Fixed

  • Followed the same steps above - ✅
  • Ran regression scenarios - ✅
  • Run automated tests - ✅

image

Fixed an issue that  caused the search feature to become unresponsive after setting an empty options  list.
@gnbm gnbm added the bug Something isn't working label Mar 29, 2024
@gnbm gnbm requested a review from sa-si-dev March 29, 2024 21:53
@gnbm gnbm merged commit fbc0d72 into master Apr 4, 2024
@gnbm gnbm deleted the Issue318v1 branch April 17, 2024 01:05
@gnbm gnbm restored the Issue318v1 branch April 17, 2024 01:05
@gnbm gnbm deleted the Issue318v1 branch April 23, 2024 20:38
@gnbm gnbm mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants