Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken 0-tick long drums with Signal Factory Sound #372

Open
spessasus opened this issue Jun 12, 2024 · 1 comment
Open

Broken 0-tick long drums with Signal Factory Sound #372

spessasus opened this issue Jun 12, 2024 · 1 comment

Comments

@spessasus
Copy link

Describe the bug
It's me again with the same MIDI file.
This time the issue is with the drum sounds, sometimes they don't play.
issue.zip (this is the exact same th06_01.mid)
This is regardless of the soundfont.

To Reproduce
Steps to reproduce the behavior:

  1. Load the MIDI file
  2. Mute everything but drums
  3. Wait for the drum section
  4. Hear inconsistent drums

Expected behavior
Drums should play fine. For example, try SpessaSynth. It works fine there.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser: Tested on both Chromium and Firefox.
  • Version:
    Chromium: Version 125.0.6422.141 (Official Build) Arch Linux (64-bit)
    Firefox: 126.0.1

Smartphone (please complete the following information):
N/A

Additional context (could be helpful)

I've faced this exact problem when making SpessaSynth. The problem is that the note ends immediately after it starts.
I fixed it by implementing a minimum allowed note length.
The line of code responsible for this.

@torbendury
Copy link

I'm facing the exact behavior as my drumkit is sending signals of length 0.

Strange enough, when I position those drum sounds manually on the piano roll, they play just fine. Maybe they're internally being mapped to a length unequal 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants