Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Guzzle Client should be injectable to be able to handle proxy #1

Open
spidgorny opened this issue Feb 27, 2018 · 3 comments
Open

Guzzle Client should be injectable to be able to handle proxy #1

spidgorny opened this issue Feb 27, 2018 · 3 comments
Labels
enhancement

Comments

@spidgorny
Copy link

Guzzle Client should be injectable to be able to handle proxy configuration and other options.

For example: GetFolderItemsCommand is constructing it's own new Client().
@ryanvade
Copy link
Owner

I agree, and will look into implementing this.

@ryanvade
Copy link
Owner

RE: This enhancement refers to code in this repository: https://github.com/ryanvade/laravel-box/

@ryanvade
Copy link
Owner

I've started a complete rewrite of the LaravelBox library, I believe your request has been sufficiently implemented.
https://github.com/ryanvade/laravel-box/blob/refactor_remove_factories/src/LaravelBox/LaravelBox.php#L18

I will mark this closed when the new version of the library is implemented.

ryanvade pushed a commit that referenced this issue Nov 26, 2018
@yatsenkolesh
listContents exception fix (#1)
9a85210
ryanvade added a commit that referenced this issue Nov 26, 2018
@ryanvade
Merge pull request #7 from yatsenkolesh/master
ae8023b 
listContents exception fix (#1)

- I appreciate the fix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spidgorny @ryanvade