Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.unwrap is used on non-guaranteed results #23

Open
ryanrixxh opened this issue Mar 26, 2023 · 0 comments
Open

.unwrap is used on non-guaranteed results #23

ryanrixxh opened this issue Mar 26, 2023 · 0 comments
Labels
good first issue Good for newcomers refactor Changes to existing functionality

Comments

@ryanrixxh
Copy link
Owner

In the main Rust code, when gathering Results .unwrap() is used to extract the value from those results. This is unsuitable for much of the production code because unwrap will panic if it finds no value or an error in the Result.

Case matching should be used instead to process these results.
@ryanrixxh ryanrixxh added enhancement New feature or request good first issue Good for newcomers labels Mar 26, 2023
@ryanrixxh ryanrixxh added refactor Changes to existing functionality and removed enhancement New feature or request labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Changes to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanrixxh