Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navbar-default From Navbar #188

Open
thechief389 opened this issue Dec 10, 2018 · 2 comments
Open

Remove navbar-default From Navbar #188

thechief389 opened this issue Dec 10, 2018 · 2 comments

Comments

@thechief389
Copy link

Some boots watch themes like solar have different navbar colors. The one I want
to use is "navbar navbar-expand-lg navbar-dark bg-primary". (bg-primary makes it yellow.)

When you convert the files to html, it adds "navbar-default" to the <div class="navbar">, which is the black one.

@Tmpod
Copy link

Tmpod commented Sep 4, 2019

I've just spotted the same issue and this is quite frustrating as it's essentially removing the customisation functionality from Bootswatch themes.

Seems it would be just a matter of removing navbar-default from here

@ryan-roemer
Copy link
Owner

ryan-roemer commented Sep 4, 2019

I'd take a PR that is verifiable from the demo app that changes:

  1. https://github.com/ryan-roemer/sphinx-bootstrap-theme/blob/master/sphinx_bootstrap_theme/bootstrap/navbar.html#L1 (probably remove navbar-default) and

  2. https://github.com/ryan-roemer/sphinx-bootstrap-theme/blob/master/sphinx_bootstrap_theme/bootstrap/theme.conf#L45-L47 default conf options (probably convert from navbar to navbar navbar-default)

to something that effectively does:

  1. If theme_navbar_class is set, use that straight up
  2. If theme_navbar_class is unset, default it's value to navbar-default

See https://github.com/ryan-roemer/sphinx-bootstrap-theme/blob/master/README.rst#contributing for how I'll test it. Feel free to give temporary options in https://github.com/ryan-roemer/sphinx-bootstrap-theme/blob/master/demo/source/conf.py#L90-L155 with comments for me to test out if you'd like as that will enable me to verify things faster! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants