Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about ordering no longer being preserved #47

Open
charlescapps opened this issue Mar 10, 2023 · 2 comments
Open

Add documentation about ordering no longer being preserved #47

charlescapps opened this issue Mar 10, 2023 · 2 comments

Comments

@charlescapps
Copy link

charlescapps commented Mar 10, 2023

Hi, I was looking into upgrading from 1.x to 2.x of tiny-async-pool, and I'm glad that I perused the source code, because it is evident that the order of the results no longer matches the order of the input data!

In the previous implementation, the order is clearly preserved because the array of ret is in the order of the input iterable.

This is rather a trap that someone could easily fall into, since the incorrect result order might not crop up in unit tests or under most circumstances!

Can we update the documentation, and/or add an example of how to preserve order?

Here's some possible code to wrap this in a way that preserves order and has 1.x semantics -

import asyncPool from "tiny-async-pool";

// Wrap tiny-async-pool with semantics of 1.x, also ensuring the order of the results
export const awaitPromisesWithConcurrency = async <IN, OUT>(
  concurrency: number,
  data: readonly IN[],
  iteratorFn: (value: IN) => Promise<OUT>
): Promise<OUT[]> => {
   // Tag the data & result with its index, to ensure the results are in the correct order
  const dataWithIndexes: [IN, number][] = data.map((value, index) => [value, index]);
  const iteratorFnWithIndex: (value: [IN, number]) => Promise<[OUT, number]> =
    ([value, index]: [IN, number]) => iteratorFn(value).then(result => [result, index]);
  const asyncIterable = asyncPool(concurrency, dataWithIndexes, promiseCreatorWithIndex);
  // Insert data in the results array in the correct index
  const results: OUT[] = [];
  for await (const [result, index] of asyncIterable) {
    results[index] = result;
  }
  return results;
};
@luoriwusheng-xia
Copy link

[en] Why can your browser or node environment run directly,
[zh-cn] 为什么你们的浏览器或者node环境能直接运行

node: 20.10.0

edge:  121.0.2277.106 

Throw an error

Uncaught SyntaxError: Unexpected reserved word

[en] Browser cannot recognize for await syntax
[zh-cn] 浏览器无法识别 for await 语法

@rxaviers
Copy link
Owner

rxaviers commented Feb 7, 2024

Hi @charlescapps, could you send a pull request with your suggestion? I am open to include it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants