Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pickling dim tags #937

Merged
merged 9 commits into from
Feb 7, 2022
Merged

Support pickling dim tags #937

merged 9 commits into from
Feb 7, 2022

Conversation

albertz
Copy link
Member

@albertz albertz commented Feb 7, 2022

@albertz albertz marked this pull request as ready for review February 7, 2022 13:45
@albertz albertz requested a review from a team as a code owner February 7, 2022 13:45
@albertz albertz requested a review from JackTemaki February 7, 2022 13:46
@albertz
Copy link
Member Author

albertz commented Feb 7, 2022 •
edited
Loading

I don't exactly understand the failing PyCharm inspection test:

  returnn/datasets/util/feature_extraction.py:310: WARNING PyArgumentListInspection: Unexpected argument
  returnn/datasets/util/feature_extraction.py:319: WARNING PyArgumentListInspection: Unexpected argument
  returnn/datasets/util/feature_extraction.py:345: WARNING PyArgumentListInspection: Unexpected argument
  returnn/datasets/util/feature_extraction.py:380: WARNING PyArgumentListInspection: Unexpected argument
  returnn/datasets/util/feature_extraction.py:411: WARNING PyArgumentListInspection: Unexpected argument

This involves librosa, for example:

  features = librosa.feature.mfcc(
    audio, sr=sample_rate,
    n_mfcc=num_feature_filters,
    hop_length=int(step_len * sample_rate), n_fft=int(window_len * sample_rate))

I assume some hick-up...

Edit This was due to librosa 0.9.0. It does not happen with librosa 0.8.1. I included that now in this PR, even though it is unrelated.

@albertz albertz mentioned this pull request Feb 7, 2022
Closed
@albertz albertz merged commit d030cde into master Feb 7, 2022
@albertz albertz deleted the albert-pickle-dim-tags branch February 7, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackTemaki JackTemaki Awaiting requested review from JackTemaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@albertz