Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF cum_concat_step simplify and other RF things #1665

Merged
merged 13 commits into from
Dec 13, 2024

Conversation

albertz
Copy link
Member

@albertz albertz commented Dec 11, 2024

(This is just here to at least run the test once before I merge it into main.)

(The other commits accidentally went into here, but it cannot hurt. Let's just not squash them together but rebase then.)

@albertz albertz requested review from NeoLegends and a team as code owners December 11, 2024 19:00
@albertz albertz marked this pull request as draft December 13, 2024 10:00
Copy link
Collaborator

@NeoLegends NeoLegends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other backends? It seems strange to me that only one backend can pad w/ non-scalar values. If we only implement this for torch I'd rather adjust the RF cum_conat_step impl to not rely on rf.pad but a more general operation that works across all backends, no?.

@albertz
Copy link
Member Author

albertz commented Dec 13, 2024

What about the other backends? It seems strange to me that only one backend can pad w/ non-scalar values. If we only implement this for torch I'd rather adjust the RF cum_conat_step impl to not rely on rf.pad but a more general operation that works across all backends, no?.

There is not really any other backend currently which fully works and is actively used, so I don't think this has such a high priority now.

@NeoLegends
Copy link
Collaborator

NeoLegends commented Dec 13, 2024

But is it much work to change the impl to be generic by default? If we ever add more tier 1 backends that is one less thing to worry about?

@albertz
Copy link
Member Author

albertz commented Dec 13, 2024

I don't exactly understand? Via this PR, rf.cum_concat_step becomes generic, so this PR here fixes this?

@NeoLegends
Copy link
Collaborator

I mean wrt. rf.pad of non-scalar values.

@albertz
Copy link
Member Author

albertz commented Dec 13, 2024

But I still don't understand? rf.pad never supported non-scalar values? Now it does for the PT backend. rf.pad is a backend function. There is no way to have this more generic?

@albertz albertz force-pushed the albert-rf-cumconcat-pure branch from 77135fa to 7b2882a Compare December 13, 2024 13:59
@albertz albertz marked this pull request as ready for review December 13, 2024 14:48
@albertz albertz merged commit 64d234b into master Dec 13, 2024
64 checks passed
@albertz albertz deleted the albert-rf-cumconcat-pure branch December 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants