Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve OpenID-Connect login button #3

Open
FBasels opened this issue Jul 5, 2021 · 0 comments
Open

[Enhancement] Improve OpenID-Connect login button #3

FBasels opened this issue Jul 5, 2021 · 0 comments

Comments

@FBasels
Copy link
Contributor

FBasels commented Jul 5, 2021

The OIDC login button could need some improvement and clean up.
Some things that come in mind are:

  • ID tokens are extracted, but not used in any way
  • ID tokens are not validated
  • there is no working logout functionality
  • validation of access token exists (via the userinfo endpoint) but no verification if the token is issued to this client

In general we could make use of the Single Sign-On functionality of Keycloak or/and make use of a JS library.
Best solution would be to just use our openidconnect-singin button, but maybe this would require some changes in the whole code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant