Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear method does not clear owned settings #85

Open
Falc opened this issue May 12, 2016 · 0 comments
Open

Clear method does not clear owned settings #85

Falc opened this issue May 12, 2016 · 0 comments

Comments

@Falc
Copy link

Falc commented May 12, 2016

I am using this bundle in a project to define a global shipping_cost setting. Since an admin can set a "discounted" shipping cost to specific customers, the setting has ALL scope. This way I can do something like $settings->get('shipping_cost', $user) to retrieve either the specific (customer) shipping cost, or the global one.

The problem appears when an admin wants to remove the specific shipping cost from the customer. It does not get deleted from the database. Instead of that, it is set to the same value as the global one. This creates a problem when the global value changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant