-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Understanding scopes #57
Comments
Option 2, which involves the namespaces, also can be seen as a simple solution for grouping settings? Making the scopes dynamic would involve changes to the database structure, so probably option 2 is the easiest solution because it solely involves changing the configuration format. |
personally, i kind of like the option 1. this way, it's possible to scope settings, on the fly. like for example, an user get new roles, so
so option 1 may get more complex.. that left us with option 2 - which is actually the easiest way ^^ |
Most of the times the easiest solution is the way to go, as long as it solves your use cases. So lets try to agree on option 2. Don't like the idea that database changes would be needed 😉 |
Agreed! Lets do option 2. |
I want to discuss planned features of this bundle. The PR (#54) from @juanolon got me thinking of this.
Currently we have 3 scopes.
GLOBAL
andUSER
where the latter requires you to provide an entity. We do also haveALL
which is some kind of default for theUSER
scope. (One can discuss if the names are proper #23).PR #54 introduce a granularity of the
USER
scope. I understand the need and I agree with it. He wants to make sure class A does not access settings of class B. (Both are naturally in theUSER
scope). This is a fix for #3.I can see some possible solution for this. I don't know which one is better. .
Option 1) Making scopes dynamic. Lets use
GLOBAL
,ALL
andDYNAMIC
and then extend theSettingsOwnerInterface
with agetScope
function.Option 2) Something more like #54 where we define a namespace and make sure the entity in the
USER
scope is an instance of that namespace.Option 3) In the configuration specify what entities that are allowed to what sections of the configuration.
Option 4) ??? There must be something else
The text was updated successfully, but these errors were encountered: