Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Use TranslationBundle while editing Settings #38

Open
rvanlaak opened this issue Jun 22, 2015 · 2 comments
Open

[RFC] Use TranslationBundle while editing Settings #38

rvanlaak opened this issue Jun 22, 2015 · 2 comments
Milestone

Comments

@rvanlaak
Copy link
Owner

The backend to edit Settings is great, especially because it just uses the Symfony form component in a proper way.

Some of my Settings require translation, that's why I'd like to know you opinion on integrating the TranslationFormBundle into your bundle. It will allow the SettingsBundle to introduce an optional config parameter:

dmishh_settings:
    settings:
        my_first_setting: 
            translatable: true

Can you maybe comment on the translation strategy to use? I'm using the KnpDoctrineExtension strategy in my application, which works great.

@dmishh dmishh added this to the 2.0.* milestone Jun 29, 2015
@dmishh
Copy link
Collaborator

dmishh commented Jun 29, 2015

This is a very cool feature! @rvanlaak It would be just amazing if you felt the power to implement it and create eventually a pull request

@rvanlaak
Copy link
Owner Author

👍 will dive into it it later this week.

@dmishh dmishh modified the milestones: 2.0, 2.1 Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants