Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The controllers should allow TranslationInterface from the component too #108

Open
Nyholm opened this issue Dec 13, 2019 · 2 comments
Open

Comments

@Nyholm
Copy link
Collaborator

Nyholm commented Dec 13, 2019

Currently we only allow TranslationInterface from Contracts. We should allow the same interface from the component too.

Symfony 3.4 is not using contracts.

@rvanlaak
Copy link
Owner

rvanlaak commented Dec 13, 2019

@rvanlaak
Copy link
Owner

rvanlaak commented Dec 13, 2019

The controller uses translations for the exception messages. The exception messages will not be visible to users, as on prod the exception message will not get shown.

In other words; the translations in the controller and the translation files can get removed, and thereby the dev dependency on symfony/translation also can get removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants