Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞 BUG]: deleting wrong option in heuristic test #435

Closed
FernandaCasali opened this issue Apr 15, 2024 · 6 comments · Fixed by #441
Closed

[🐞 BUG]: deleting wrong option in heuristic test #435

FernandaCasali opened this issue Apr 15, 2024 · 6 comments · Fixed by #441
Assignees
Labels
Bug Something isn't working doing This issue is being done by somebody

Comments

@FernandaCasali
Copy link
Member

Description 📝

When you click on delete the option, it always deletes the last option you have and not the one you want.

Link 🔗

\src\components\molecules\OptionsTable.vue

Steps to Reproduce 🔄

Screenshots 📸

Expected Behavior 🤔

Actual Behavior 😱

Environment 🌍

Additional Information ℹ️

No response

@FernandaCasali FernandaCasali added the Bug Something isn't working label Apr 15, 2024
@sajontahsen
Copy link
Contributor

Interested. Can i try?

@KarinePistili
Copy link
Member

Yes, you can! Assigned @LostSputnik

@KarinePistili KarinePistili added the doing This issue is being done by somebody label Apr 15, 2024
@sajontahsen
Copy link
Contributor

sajontahsen commented Apr 16, 2024

Hello, hope you're doing all right!
So I set up the project with firebase emulator and attempted to recreate the problem on my local system. I have some interesting observations that I wanted to discuss.

  • The bug seems to be there only for options with no value, i.e the ones where we uncheck the Has Value checkbox.
  • Deleting seems to work properly for options that do have a value
  • For cases where both kinds of option exists, the bug is exclusive to the ones without values.

I tried a number of test cases to assess this, such as where there are options with value after the ones without, and vise versa, as well as checking if deleting one type of option affects the other. I also checked combinations of the order of these two types of options to check if that had any effect. In all these, the above points seem to hold true. Here, I'm attaching a screen-recording so you can have a better insight, and also to make sure my process is aligned with the intended use.

Google Drive Link to Video

ruxailab-issue-435-0-20240416.mp4

I plan to first look into those options that don't have value, and work my way up from there. Am I on the right track? Eager to hear your thoughts on this. Thanks!

@KarinePistili @FernandaCasali

@sajontahsen
Copy link
Contributor

I went ahead and made the PR, so that we have a basis to discuss further. Please me know if it aligns with the requirements. Thanks again ^_^

@KarinePistili
Copy link
Member

Thanks @LostSputnik !! We will test it out and ping you back with feedback!

@sajontahsen
Copy link
Contributor

You're welcome @KarinePistili. I believe I also came across a bug related to editing the option description. Let's look at that once we're done with this first.

jvJUCA added a commit that referenced this issue Apr 17, 2024
…-in-heuristic-test

Issue #435: deleting wrong option in heuristic test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working doing This issue is being done by somebody
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants