Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Support for Easier Project Setup and Deployment #360

Closed
TheMohit2003 opened this issue Mar 8, 2024 · 16 comments
Closed

Add Docker Support for Easier Project Setup and Deployment #360

TheMohit2003 opened this issue Mar 8, 2024 · 16 comments
Assignees
Labels
doing This issue is being done by somebody Enhancement New feature or request Review Check or stud something

Comments

@TheMohit2003
Copy link
Contributor

TheMohit2003 commented Mar 8, 2024

Feature Description 📝

Implement Docker support for the project to streamline the setup process, ensuring that all contributors can work within a consistent and isolated development environment. This includes creating a Dockerfile for the application and, if necessary, a docker-compose.yml file to manage multi-container setups, including the application and its database.

Motivation 🌟

The motivation behind this proposal stems from numerous setup issues faced by contributors, attributed to varying system configurations and dependency management challenges. These issues not only hinder new contributors from setting up the project efficiently but also introduce inconsistencies across development environments.

Expected Behavior 🤔

  • Contributor should be able to set up the project with minimal steps, essentially requiring only Docker installation and running a couple of docker commands
@TheMohit2003 TheMohit2003 added the Enhancement New feature or request label Mar 8, 2024
@TheMohit2003 TheMohit2003 changed the title [✨ FEATURE]: Add Docker Support for Easier Project Setup and Deployment Add Docker Support for Easier Project Setup and Deployment Mar 8, 2024
@TheMohit2003
Copy link
Contributor Author

@jvJUCA , what do you think of this ?

@ritikprajapat21
Copy link

Hi, @TheMohit2003
Is anyone there who is assigned on the issue.
If not then I would like to give this a try.

@TheMohit2003
Copy link
Contributor Author

Hey @ritikprajapat21 , I have already created a docker file for this . I am just waiting for project owners for their opinion.

@jvJUCA
Copy link
Member

jvJUCA commented Mar 11, 2024

Dear @TheMohit2003 ,

Thank you for initiating the discussion and proposing the implementation of Docker support for our project. Our team fully supports this decision and believes it will greatly benefit both current and future contributors.

Having Docker support will streamline the setup process, making it easier for everyone to get started with the project regardless of their system configurations. This will undoubtedly enhance collaboration and ensure consistency across development environments.

We would be incredibly grateful if you could proceed with this contribution. Your effort in implementing Docker support will undoubtedly make a significant impact on the project, enabling smoother onboarding for contributors and fostering a more cohesive development experience.

If you need any assistance or have any questions throughout the process, please don't hesitate to reach out.

Once again, thank you for your initiative and dedication to improving our project.

Best regards,
@jvJUCA

@jvJUCA jvJUCA assigned jvJUCA and TheMohit2003 and unassigned jvJUCA Mar 11, 2024
@asr2003
Copy link

asr2003 commented Mar 11, 2024

@TheMohit2003 Are you currently adding Docker support for dev env?

@TheMohit2003
Copy link
Contributor Author

@asr2003 , yes .

@abhisek-1221
Copy link
Contributor

@TheMohit2003 Good initiative. Good Luck !

@TheMohit2003
Copy link
Contributor Author

TheMohit2003 commented Mar 13, 2024

@jvJUCA Should we add Nginx to serve our Vue app, or just use serve with npm to expose it on a port? I am talking about using nginx image in our Dockerfile to serve the build files.

@jvJUCA
Copy link
Member

jvJUCA commented Mar 13, 2024

@jvJUCA Should we add Nginx to serve our Vue app, or just use serve with npm to expose it on a port? I am talking about using nginx image in our Dockerfile to serve the build files.

Dear @TheMohit2003 ,

Our team prefers sticking with serve to expose our Vue application on a port. We've chosen this approach due to its simplicity and ease of configuration. serve is a lightweight and straightforward tool for serving static files, requiring minimal setup.

Best regards,
@jvJUCA

@Tufailahmed-Bargir
Copy link

Tufailahmed-Bargir commented Mar 19, 2024

hey @TheMohit2003 have you manage to do Docker setup??? I am also interested in doing so if you have no issues

@TheMohit2003
Copy link
Contributor Author

@Tufailahmed-Bargir , yep, already done . Will push it soon .

@Tufailahmed-Bargir
Copy link

does doing Docker setup is challenging??

@xemyst
Copy link
Member

xemyst commented Mar 21, 2024

@Tufailahmed-Bargir , yep, already done . Will push it soon .

Sorry for late answering. 🙏
A good option can be creating two docker images, one for dev, with the volume links to the current folder to dev locally. Another for deployment with a nginxserver to serve the file.

@TheMohit2003
Copy link
Contributor Author

TheMohit2003 commented Mar 22, 2024

@xemyst , i did asked the main members if we needed nginx , but they clearly said as of now they would want to keep the project image as simple as possible . So i am just exposing the build at a port without using any base nginx image.
Hey @jvJUCA , any point regarding @xemyst argument .

@KarinePistili
Copy link
Member

Hello, @TheMohit2003 you can follow up as described on the review of your PR: #395

@KarinePistili KarinePistili added Review Check or stud something doing This issue is being done by somebody labels Apr 15, 2024
@TheMohit2003
Copy link
Contributor Author

@KarinePistili yeah , I will make changes to the file as said .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doing This issue is being done by somebody Enhancement New feature or request Review Check or stud something
Projects
None yet
Development

No branches or pull requests

8 participants