Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported export syntax #74

Open
Fee0 opened this issue Nov 24, 2022 · 5 comments
Open

Unsupported export syntax #74

Fee0 opened this issue Nov 24, 2022 · 5 comments
Assignees

Comments

@Fee0
Copy link

Fee0 commented Nov 24, 2022

Following syntax seems to be not supported:

export * as A from "M";

Tested on source location branch

@FreeMasen
Copy link
Collaborator

Thank you for the bug report!

@FreeMasen
Copy link
Collaborator

Is this something you would be interested in fixing?

@FreeMasen
Copy link
Collaborator

This bug will most likely require a change to resast since the ModExportSpecifier::All doesn't have the ability to handle the identifier.

Alternatively the method parse_all_export could return a ModExportSpecifier::Named in this case, which I believe would avoid a version bump for the breaking change but I don't really love having the ExportSpecifier::local property be an Ident with "*" as the value which is technically not a valid identifier.

We could push the later into 0.8.1 and slate the former for a 0.9.0 update

@FreeMasen
Copy link
Collaborator

For reference, I have created rusty-ecma/resast#7

@Fee0
Copy link
Author

Fee0 commented Nov 25, 2022

I would prefer the AST to be in clean state with all identifier really being identifier.
I can take a look when time permits but at the moment it's not a priority for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants