Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punct Ident Prefix #45

Open
FreeMasen opened this issue Aug 27, 2019 · 0 comments
Open

Punct Ident Prefix #45

FreeMasen opened this issue Aug 27, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed make good first issue Could be a good first issue if more details were provided

Comments

@FreeMasen
Copy link
Collaborator

FreeMasen commented Aug 27, 2019

The primary method for handling # and @ is to support them as single character puncts and force the caller to deal with the repercussions (what we do currently).

It may make more sense to treat these as extentions to ident_start similar to the inclusion of _ and $. The plus side here is that the caller would have less to do after tokenization, the negative is that we would be pretty tied to the proposal as it is today and if it were to change then we would have much more work to remove the code.

One possibility would be to also extend the Ident struct to have is_decorator and is_private methods.

@FreeMasen FreeMasen added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Aug 27, 2019
@FreeMasen FreeMasen added make good first issue Could be a good first issue if more details were provided and removed question Further information is requested labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed make good first issue Could be a good first issue if more details were provided
Projects
None yet
Development

No branches or pull requests

1 participant