Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read WebDriver paths from env at highest priority #1127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Read WebDriver paths from env at highest priority #1127

wants to merge 1 commit into from

Conversation

thisisrandy
Copy link

Make sure these boxes are checked! 📦✅

  • [ x] You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • [ x] You ran cargo fmt on the code base before submitting
  • [ x] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

This closes #1126. A separate PR will be submitted for wasm-bindgen to update the docs.

@thisisrandy thisisrandy mentioned this pull request Apr 15, 2022
Merged
@chris13524
Copy link

Thank you for this contribution! Your branch solves my use case

@thisisrandy
Copy link
Author

The failing test seems to be failing in rustwasm:master and unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headless chrome test fails due to incorrect chromedriver version
2 participants
@thisisrandy @chris13524