-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromedriver download using outdated endpoints. #1315
Comments
Since the PR doesn't receive response for a long time. I change by GitHub action for latest chrome for testing. I put it here for people who need it:
|
Thanks for your workaround! I would really be great getting #1325 in to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug description
In our test suite we download the lastest chrome beta version and test our code against it headlessly with wasm-pack. Wasm-pack was happily downloading a compatible version of chromedriver for us and everything was good.
Today it stopped working, after a bit of digging we found this:
🤔 Expected Behavior
Previous behaviour was to download
LATEST_RELEASE
of chromedriver which was the latest stable release:https://github.com/rustwasm/wasm-pack/blob/master/src/test/webdriver/chromedriver.rs#L12
Which, being one version away from Beta, was deemed compatible. However Google have changed their process and this URL is now abandoned at M114 in favour of new download URLs and endpoints.
See this announcement here:
https://groups.google.com/g/chromedriver-users/c/clpipqvOGjE
And their new site here:
https://googlechromelabs.github.io/chrome-for-testing
👟 Steps to reproduce
On our x86_64 debian based CI container, our process was as follows:
CHROMEDRIVER_ARGS="--verbose" wasm-pack test --chrome --headless
🌍 Your environment
Include the relevant details of your environment.
wasm-pack version:
wasm-pack 0.12.1
rustc version:
rustc 1.72.0-nightly (f4b80cacf 2023-06-30)
Mitigation
We are currently mitigating this behaviour by manually downloading the chromedriver binary like this:
The text was updated successfully, but these errors were encountered: