Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop recommending wee_alloc #282

Open
rparrett opened this issue Oct 27, 2022 · 2 comments
Open

Stop recommending wee_alloc #282

rparrett opened this issue Oct 27, 2022 · 2 comments

Comments

@rparrett
Copy link

Where in the docs did you come across this?

https://rustwasm.github.io/docs/book/reference/code-size.html#avoid-allocation-or-switch-to-wee_alloc

Describe what about it does not make sense

Switching to wee_alloc is not good advice.

Why does it not make sense?

wee_alloc is unmaintained and has a serious memory leak bug.

See RUSTSEC-2022-0054 and rustwasm/wee_alloc#106

How could we improve it?

Remove references to wee_alloc.

Perhaps replace them with references to lol_alloc which has been suggested as an alternative.

But IMO this paragraph shouldn't speak about allocator-swapping as a mere tradeoff between speed and size.

@ptdecker
Copy link

ptdecker commented Feb 7, 2023

I'll second this request. GitHub's dependabot flags it as a critical security issue:

https://github.com/ptdecker/the-rust-programming-language/security/dependabot/1

@spencerbart
Copy link

I'll third this request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants