Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi_mut is unsound #1531

Open
Shnatsel opened this issue Jan 17, 2023 · 3 comments · May be fixed by #1553
Open

multi_mut is unsound #1531

Shnatsel opened this issue Jan 17, 2023 · 3 comments · May be fixed by #1553

Comments

@Shnatsel
Copy link
Member

https://github.com/golddranks/multi_mut has been written before Rust had an aliasing model, and before &mut had noalias annotations in LLVM. It violates Stacked Borrows and is likely UB under current LLVM behavior:

golddranks/multi_mut#1
@Shnatsel
Copy link
Member Author

Shnatsel commented Jan 17, 2023 •
edited
Loading

Ideally we should understand the practical implications of this before filing an advisory.

@pinkforest
Copy link
Contributor

We could perhaps just flag unmaintained and mention the soundness issue perhaps - last release was like 6 years ago

@pinkforest
Copy link
Contributor

There is also https://crates.io/crates/splitmut - https://www.reddit.com/r/rust/comments/5ofuun/comment/dcj7she/?utm_source=share&utm_medium=web2x&context=3

hasn't been updated for five years

@pinkforest pinkforest linked a pull request Feb 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unmaintained multi_mut pinkforest/advisory-db
2 participants
@Shnatsel @pinkforest