Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jni 0.21 migration #22

Closed
cpu opened this issue Aug 25, 2023 · 3 comments
Closed

jni 0.21 migration #22

cpu opened this issue Aug 25, 2023 · 3 comments
Labels
O-Android Work related to the Android verifier implementation

Comments

@cpu
Copy link
Member

cpu commented Aug 25, 2023

Presently this crate uses jni-rs v0.19 as an optional dependency for doc generation, and a required dependency for the Android OS target.

The latest release stream, 0.21.x, "makes extensive breaking changes in order to improve safety. Most projects that use this library will need to be changed accordingly.". The upstream project offers a migration guide to help with this process.

Given the advertised safety improvements it's likely worthwhile to consider the steps required for migration.

@complexspaces
Copy link
Collaborator

Thanks for taking a glance at this! The new safety improvements look very welcome. Our uses are pretty simple so I'm hoping our upgrade path is pretty smooth.

@cpu cpu assigned cpu and unassigned cpu Aug 31, 2023
@complexspaces complexspaces added the O-Android Work related to the Android verifier implementation label Jan 4, 2024
@akonradi-signal
Copy link

Is this fixed by #151?

@djc
Copy link
Member

djc commented Dec 12, 2024

Yes.

@djc djc closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Android Work related to the Android verifier implementation
Projects
None yet
Development

No branches or pull requests

4 participants