Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.c test ECH support updates #503

Closed
cpu opened this issue Dec 13, 2024 · 1 comment · Fixed by #504
Closed

client.c test ECH support updates #503

cpu opened this issue Dec 13, 2024 · 1 comment · Fixed by #504
Assignees

Comments

@cpu
Copy link
Member

cpu commented Dec 13, 2024

Upstream we made some tweaks to the ech-client.rs example (rustls/rustls#2278) that motivates making a few changes to this repo's equivalent.

  • The ech_fetch.rs util should be updated to write EchConfigListBytes files for each of the HTTPS records fetched, not just the first.
  • The client.c test should be updated to accept a directory of ECH config list files in an env var instead of a single file.
  • We might want to make some API changes to make it easier to filter many config lists into one working client config.
@cpu
Copy link
Member Author

cpu commented Dec 14, 2024

Fix is #504

The client.c test should be updated to accept a directory of ECH config list files in an env var instead of a single file.

I decided it was easier to make the env var a comma separated list of file paths.

We might want to make some API changes to make it easier to filter many config lists into one working client config.

It turns out the existing API is fine. It's pretty close to how you do this w/ the Rust API as well: try to convert each into an ECH mode. Stop for the first good one. Error if none are good.

@cpu cpu closed this as completed in #504 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant