Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for rustls 0.21 support #294

Closed
5 tasks done
jsha opened this issue Mar 21, 2023 · 8 comments
Closed
5 tasks done

Tracking issue for rustls 0.21 support #294

jsha opened this issue Mar 21, 2023 · 8 comments

Comments

@cpu
Copy link
Member

cpu commented Mar 22, 2023

Here are a couple other issues that I think will need to be handled:

I proposed fix patches in the first two issues (but haven't opened a PR since it's an "all or nothing" type thing to get the build green). I think I might be able to make some progress on #297 if that would be helpful.

@jsha
Copy link
Collaborator Author

jsha commented Mar 22, 2023

Yeah, if you'd like to start in on #297 that would be great!

I'll start a rustls-0.21.0 branch to accumulate fixes.

@jsha
Copy link
Collaborator Author

jsha commented Mar 22, 2023

Here's the initial commit on the rustls-0.21.0 branch. From here let's do pull requests against it. I intended to make this first commit a PR but accidentally pushed straight to it. I've enabled branch protection on it now.

@cpu
Copy link
Member

cpu commented Mar 22, 2023

@jsha Do you want to strike #293 from the burndown list based on #301 landing? It seems like leaving the issue open for future implementation might make sense but it isn't a release blocker now.

@cpu
Copy link
Member

cpu commented Mar 23, 2023

I made a quick branch on top of rustls-0.21.0 that integrates #305, #303, and #306 (cpu-0.21.0-smoketest) to see if CI would build 🟢.

The results were promising, only one task of the Windows CMake, Debug configuration job failed for "check static library list":

Run python tests/verify-static-libraries.py
got unexpected list of native static libraries, fix or update README: advapi32.lib credui.lib kernel32.lib secur32.lib kernel32.lib advapi32.lib userenv.lib kernel32.lib kernel32.lib ws2_32.lib bcrypt.lib msvcrt.lib legacy_stdio_definitions.lib instead of advapi32.lib credui.lib kernel32.lib secur32.lib legacy_stdio_definitions.lib kernel32.lib advapi32.lib userenv.lib kernel32.lib kernel32.lib ws2_32.lib bcrypt.lib msvcrt.lib legacy_stdio_definitions.lib
Error: Process completed with exit code [1](https://github.com/cpu/rustls-ffi/actions/runs/4502783181/jobs/7925091632#step:6:1).

@cpu
Copy link
Member

cpu commented Mar 23, 2023

only one task of the Windows CMake, Debug configuration job failed for "check static library list":

Here's a potential fix: #307 That was the last change required to get the branch passing.

@cpu
Copy link
Member

cpu commented Mar 23, 2023

We're done! 🎉

@jsha
Copy link
Collaborator Author

jsha commented Mar 23, 2023

Yay! Thanks for all your work on this.

@jsha jsha closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants