-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Considering adding constant for the PKIX Algorithm Identifier #27
Comments
I don't really object to this, though it will make adding algorithm support to webpki slightly more time-consuming. But equally don't want anyone to think that somehow this somehow is a master list, or that they need to land a PR here to implement a different algorithm. You can do, eg, |
It sounds like with the right documentation reminding folks of the @stormshield-gt I suspect the core maintainers won't have a chance to prioritize this work. Would you be interested in making the required PRs against this repo, webpki, and rustls? If you aren't that's OK but I will probably suggest closing this issue in that case. |
I will be open to make the required PRs but I think I want to delay this until I submit my PR on
The best API I can I think of would be a |
When implementing a crypto provider only for signature, I'm obligated to add a direct dependency to
webkpi
in order to benefit from the constant of the webkpi::alg_id module . The rustls' verify example for provider does the same thingIt would be nice if
pki-types
do provide this constants because it will ensure we are using the version ofwebpki
of whatever therustls
crate is using.Basically, it would mean to migrate the webkpi::alg_id module here.
Are you open to that kind of changes?
The text was updated successfully, but these errors were encountered: