Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jilu doesn't play nicely with incorrect formatted release tags #21

Open
MTRNord opened this issue Aug 21, 2020 · 1 comment
Open

Jilu doesn't play nicely with incorrect formatted release tags #21

MTRNord opened this issue Aug 21, 2020 · 1 comment

Comments

@MTRNord
Copy link

MTRNord commented Aug 21, 2020

Hi we switched to this and previously made tags that do not follow semver.

We have many that started with release- instead of v and have one starting with v (v0.1.0).

While it correctly ignores the release- ones (thats totally fine) it now causes a weird bug. We now had made a v0.23.0 tag and have the super old v0.1.0 Tag. But instead of putting the v0.23.0 changes under that part in the changelog it actually seems to put the changes under the 0.1.0 release.

I am not sure if thats because we had many invalid tags or the problem is elsewhere. But it also lists only changes from the last incorrect tag until 0.23.0. And not from 0.1.0 to 0.23.0. So it seems to correctly filter them but puts the into the wrong version.

@MTRNord
Copy link
Author

MTRNord commented Aug 21, 2020

The default template did generate this:

Wrong
# Changelog

All notable changes to this project are documented in this file.

The format is based on [Keep a Changelog], and this project adheres to
[Semantic Versioning]. The file is auto-generated using [Conventional Commits].

[keep a changelog]: https://keepachangelog.com/en/1.0.0/
[semantic versioning]: https://semver.org/spec/v2.0.0.html
[conventional commits]: https://www.conventionalcommits.org/en/v1.0.0/

## Overview

- [unreleased](#unreleased)
- [`0.23.0`](#0230) – _2020.08.21_
- [`0.1.0`](#010) – _2019.07.30_

## _[Unreleased]_

_nothing new to show for… yet!_

## [0.23.0] – _Famedly 0.23.0_

_2020.08.21_

Famedly 0.23.0

## [0.1.0]

_2019.07.30_

### Contributions

This release is made possible by the following people (in alphabetical order).
Thank you all for your contributions. Your work – no matter how significant – is
greatly appreciated by the community. 💖

#### update

- **changelog** ([`69f7083`])

- **Update release docs to new workflow** ([`d201cec`])

#### Bug Fixes

- **Disable background push on android** ([`507a54e`])

- **wait during client dispose** ([`149c7c7`])

- **In the Changelog Task the CI complains about 2 folders** ([`55a1876`])

  The CI Complains about `doc-public/` and `public/` not getting staged. This should ignore this and therefor make the CI task work

- **Add Missing commands to the CI task** ([`769e0d6`])

- **Update branch from master to main** ([`2b89960`])

#### Refactoring

- **Matrix Chat List** ([`2e35524`])

- **omit _backgroundMessagesBeingHandled** ([`ab4d6ee`])

- **use completer instead of polling** ([`798edbd`])

#### Features

- **Display emoji messages bigger** ([`9630672`])

- **Make jilu run in CI on manual trigger** ([`446c8d4`])

- **Update changelog to jilu** ([`a419156`])

#### Miscellaneous Tasks

- **Update SDK** ([`cb32760`])

#### Code Styling

- **Change package:famedly imports to relative imports** ([`43303e0`])

  Changing the imports from `package:famedly` to relative imports allows us to easier move the files to a whitelabel sdk solution which is upcoming soon

#### repo

- **Make CI ready for change from master to main.** ([`42e7f75`])

#### Change

- **Hide status bar** ([`20d0af9`])

<!-- [releases] -->

[unreleased]: #/compare/v0.23.0...HEAD
[0.23.0]: #/releases/tag/v0.23.0
[0.1.0]: #/releases/tag/v0.1.0

<!-- [commits] -->

[`69f7083`]: #/commit/69f708380f80169bca9d625f94bab7a8534f3d0d
[`507a54e`]: #/commit/507a54e2c3c1011da5bfcb754fdff5288c459474
[`2e35524`]: #/commit/2e355248d44610c45bfc51b23fd81be0c945dbb1
[`9630672`]: #/commit/96306724dd754a552958552e8134bd6375fcaadd
[`cb32760`]: #/commit/cb327604323d3085dac2b6d7bd62988a8e28ecd9
[`149c7c7`]: #/commit/149c7c7dab33e4f973572b13bcee58e6beeb8870
[`ab4d6ee`]: #/commit/ab4d6ee8c04a8199c509e6b2577c083744b13552
[`798edbd`]: #/commit/798edbd406497a8ead180b89ec0ef49b04d346e8
[`43303e0`]: #/commit/43303e0ce4511f7150f59a93ddb931f0209007a4
[`55a1876`]: #/commit/55a18766548fa723ec002c24e8becb093b8c8571
[`769e0d6`]: #/commit/769e0d63d14e1d9c779d7270090dc49056d47e56
[`2b89960`]: #/commit/2b899606bdcd1878cf603d787e51a7cc28622487
[`d201cec`]: #/commit/d201cec40e0289d4bdd51cfe3afa67a27fe63912
[`446c8d4`]: #/commit/446c8d482b1f4a915d03de4db0180878d9b39391
[`a419156`]: #/commit/a4191562c60f3043fcfa64f9f041c781f75594aa
[`42e7f75`]: #/commit/42e7f754af8beda474e6c0895e2076a041403340
[`20d0af9`]: #/commit/20d0af9322f44625dfa5158a8389678691ffcaac

Expected is this:

Expected
# Changelog

All notable changes to this project are documented in this file.

The format is based on [Keep a Changelog], and this project adheres to
[Semantic Versioning]. The file is auto-generated using [Conventional Commits].

[keep a changelog]: https://keepachangelog.com/en/1.0.0/
[semantic versioning]: https://semver.org/spec/v2.0.0.html
[conventional commits]: https://www.conventionalcommits.org/en/v1.0.0/

## Overview

- [unreleased](#unreleased)
- [`0.23.0`](#0230) – _2020.08.21_
- [`0.1.0`](#010) – _2019.07.30_

## _[Unreleased]_

_nothing new to show for… yet!_

## [0.23.0] – _Famedly 0.23.0_

_2020.08.21_

Famedly 0.23.0

### Contributions

This release is made possible by the following people (in alphabetical order).
Thank you all for your contributions. Your work – no matter how significant – is
greatly appreciated by the community. 💖

#### update

- **changelog** ([`69f7083`])

- **Update release docs to new workflow** ([`d201cec`])

#### Bug Fixes

- **Disable background push on android** ([`507a54e`])

- **wait during client dispose** ([`149c7c7`])

- **In the Changelog Task the CI complains about 2 folders** ([`55a1876`])

  The CI Complains about `doc-public/` and `public/` not getting staged. This should ignore this and therefor make the CI task work

- **Add Missing commands to the CI task** ([`769e0d6`])

- **Update branch from master to main** ([`2b89960`])

#### Refactoring

- **Matrix Chat List** ([`2e35524`])

- **omit _backgroundMessagesBeingHandled** ([`ab4d6ee`])

- **use completer instead of polling** ([`798edbd`])

#### Features

- **Display emoji messages bigger** ([`9630672`])

- **Make jilu run in CI on manual trigger** ([`446c8d4`])

- **Update changelog to jilu** ([`a419156`])

#### Miscellaneous Tasks

- **Update SDK** ([`cb32760`])

#### Code Styling

- **Change package:famedly imports to relative imports** ([`43303e0`])

  Changing the imports from `package:famedly` to relative imports allows us to easier move the files to a whitelabel sdk solution which is upcoming soon

#### repo

- **Make CI ready for change from master to main.** ([`42e7f75`])

#### Change

- **Hide status bar** ([`20d0af9`])


### Changes

## [0.1.0]

_2019.07.30_

<!-- [releases] -->

[unreleased]: #/compare/v0.23.0...HEAD
[0.23.0]: #/releases/tag/v0.23.0
[0.1.0]: #/releases/tag/v0.1.0

<!-- [commits] -->

[`69f7083`]: #/commit/69f708380f80169bca9d625f94bab7a8534f3d0d
[`507a54e`]: #/commit/507a54e2c3c1011da5bfcb754fdff5288c459474
[`2e35524`]: #/commit/2e355248d44610c45bfc51b23fd81be0c945dbb1
[`9630672`]: #/commit/96306724dd754a552958552e8134bd6375fcaadd
[`cb32760`]: #/commit/cb327604323d3085dac2b6d7bd62988a8e28ecd9
[`149c7c7`]: #/commit/149c7c7dab33e4f973572b13bcee58e6beeb8870
[`ab4d6ee`]: #/commit/ab4d6ee8c04a8199c509e6b2577c083744b13552
[`798edbd`]: #/commit/798edbd406497a8ead180b89ec0ef49b04d346e8
[`43303e0`]: #/commit/43303e0ce4511f7150f59a93ddb931f0209007a4
[`55a1876`]: #/commit/55a18766548fa723ec002c24e8becb093b8c8571
[`769e0d6`]: #/commit/769e0d63d14e1d9c779d7270090dc49056d47e56
[`2b89960`]: #/commit/2b899606bdcd1878cf603d787e51a7cc28622487
[`d201cec`]: #/commit/d201cec40e0289d4bdd51cfe3afa67a27fe63912
[`446c8d4`]: #/commit/446c8d482b1f4a915d03de4db0180878d9b39391
[`a419156`]: #/commit/a4191562c60f3043fcfa64f9f041c781f75594aa
[`42e7f75`]: #/commit/42e7f754af8beda474e6c0895e2076a041403340
[`20d0af9`]: #/commit/20d0af9322f44625dfa5158a8389678691ffcaac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant