Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smol_str #3991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BenjaminBrienen
Copy link

@BenjaminBrienen BenjaminBrienen commented Nov 10, 2024

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

smol_str is part of the crate's API, which causes type mismatches that can't be resolved downstream.

@kchibisov
Copy link
Member

Unless you use winit master this won't solve anything, and you can use as many crates as you want and cast things if you use newer version of smol_str.

I'm not against updating it now, I just want to get rid of it entirely in 0.31, and this can not be backported.

I don't mind temporary bumping on master though if someone needs it.

@BenjaminBrienen
Copy link
Author

BenjaminBrienen commented Nov 10, 2024

Well it has to be updated in master before it gets released, right? It's fine if it takes time. This is just the step to get the ball rolling.

edit: I see you want to remove it entirely in 0.31. You can just close this issue if this is not the direction winit is moving. Sorry!

@kchibisov
Copy link
Member

Sure, I just tend to update all the deps closer to release date, so you don't update more than once during cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants