Add option to use Window.requestIdleCallback() for ControlFlow::Poll
#3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested review from
jackpot51,
msiglreith,
madsmtm and
kchibisov
as code owners
daxpedda
force-pushed
the
web-request-idle-callback-2
branch
from
577db5f to
43aa7b0
Compare
daxpedda
force-pushed
the
web-request-idle-callback-2
branch
from
43aa7b0 to
f1d6191
Compare
daxpedda
force-pushed
the
web-request-idle-callback-2
branch
from
f1d6191 to
53bff7f
Compare
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #3056 and adds a new extension method on
EventLoopWindowTargetto set the strategy forControlFlow::Poll. By default the Prioritized Task Scheduling API is used, this adds the option to useWindow.requestIdleCallback()instead.Both strategies fallback on
setTimeout()when not available.Cc @GloopShlugger.
Originally implemented in #2880 and then reverted in #3044.
Requires #3056.