Add support for iOS/tvOS/watchOS/visionOS #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
ios
branch
3 times, most recently
from
dcf429b
to
bbcfcaf
Compare
9 tasks
daxpedda
approved these changes
Sep 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general clean-up of the CoreGraphics implementation, instead of creating a new
NSViewand rendering into the layer there, we create a sublayer. See the code comments, and also gfx-rs/wgpu#6107 for some of the design decisions around this.This is also a step forwards for making
softbufferusable from a separate thread on Apple platforms, asCALayeris fully thread safe (whereasNSView/UIViewaren't).Finally, it removes our dependence on having access to
NSView, paving the way for a future whereraw-window-handlemay only provideCALayer.Fixes #43.