Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for translations #72

Open
Robbe7730 opened this issue Feb 9, 2021 · 7 comments
Open

Support for translations #72

Robbe7730 opened this issue Feb 9, 2021 · 7 comments

Comments

@Robbe7730
Copy link

The GTFS standard also supports translations in translations.txt. It would be nice to have these available too.

@antoine-de
Copy link
Collaborator

sure, it would be nice! I have not read the specifications for translations, but I'd sure be okay to review a PR on this!

@Robbe7730
Copy link
Author

Sure, I'll gladly look into implementing this. Do you have any pointers on where to start? It isn't quite clear to me what the difference between raw_gtfs and regular gtfs is.

@antoine-de
Copy link
Collaborator

oups the documentation might be lacking a bit 😰

RawGtfs is quite close to the files representation while Gtfs is a bit easier to use (mainly less errors, and a Arc<Stop> in the stoptime to ease use.

I think for the translations, you can just add one Translation struct close to what is in the spec and add

pub struct RawGtfs {
    //... other fields
    pub translations: Result<Vec<Translation>, Error>,
}

and an easy to use structure in the Gtfs. Maybe a HashMap<(ObjectType, String), Translation>? Or HashMap<ObjectType, HashMap<String, Translation>>?

Would this be easy to use for you? Since you're the first user, you are in the best seat to know what is easy to use 😀

@kylerchin
Copy link
Contributor

It appears progress has stalled. I'm happy to work on this, is that alright?

@antoine-de
Copy link
Collaborator

sure !

do you have an idea of the best way to represent this in the GTFS for the translations to be easy to use?

@Robbe7730
Copy link
Author

This has indeed been on the back-burner for a while now, and I don't really have the time to spend on it, but if I can help in any way feel free to contact me 🙂

@kylerchin
Copy link
Contributor

What is left for completion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants