Convert LF to CRLF when writing to serial port #474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473
I'm not sure if this is the best way to implement this in terms of performance.
This fixes the issue withUPDATE: I forgot to change theLockedLogger
, but the logging that gets done before that still doesn't use CRLF, which is why I marked this as a draft PR.bootloader
dependency in Cargo.toml, after changing it all logging was as expected.Without this change
With this change: