We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What would you think about simplifying the expression tree by
SubExpr
Add(Mul(-1, expr))
AddExpr(left, right)
AddExpr(Vec<expr>)
This is not perfect, but should be easy to implement as a workaround for now. Would you accept such a PR ?
A more ambitious refactor that we can keep for later is to implement the expression as a simple HashMap<Variable, Coefficient>.
HashMap<Variable, Coefficient>
The text was updated successfully, but these errors were encountered:
is it still relevant after last commits ?
Sorry, something went wrong.
removing Subexpr would significantly simplify the code. And restructuring the struct to have only a sum of multiplications would improve performance
No branches or pull requests
What would you think about simplifying the expression tree by
SubExpr
(and replacing it withAdd(Mul(-1, expr))
AddExpr(left, right)
byAddExpr(Vec<expr>)
, to avoid creating deep trees (that cause Simplify overflows the stack #37)This is not perfect, but should be easy to implement as a workaround for now. Would you accept such a PR ?
A more ambitious refactor that we can keep for later is to implement the expression as a simple
HashMap<Variable, Coefficient>
.The text was updated successfully, but these errors were encountered: