Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustify test.sh #384

Merged
merged 34 commits into from
Dec 19, 2023
Merged

Rustify test.sh #384

merged 34 commits into from
Dec 19, 2023

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@GuillaumeGomez
Copy link
Member Author

Note for myself: show the stdout/stderr of a command if it failed.

@GuillaumeGomez GuillaumeGomez force-pushed the rustify-test branch 9 times, most recently from e50f454 to e0f7d85 Compare November 24, 2023 21:23
@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review November 24, 2023 23:05
antoyo
antoyo reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the review of everything except one file ;) .

.github/workflows/stdarch.yml Show resolved Hide resolved
build_system/src/build.rs Show resolved Hide resolved
build_system/src/build.rs Show resolved Hide resolved
build_system/src/build.rs Outdated Show resolved Hide resolved
build_system/src/config.rs Show resolved Hide resolved
build_system/src/config.rs Outdated Show resolved Hide resolved
build_system/src/config.rs Outdated Show resolved Hide resolved
build_system/src/utils.rs Outdated Show resolved Hide resolved
build_system/src/utils.rs Outdated Show resolved Hide resolved
build_system/src/utils.rs Outdated Show resolved Hide resolved
antoyo
antoyo reviewed Nov 29, 2023
View reviewed changes
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
antoyo
antoyo reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all for now.

build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 14, 2023
Closed
antoyo
antoyo reviewed Dec 16, 2023
View reviewed changes
build_system/src/utils.rs Outdated Show resolved Hide resolved
@antoyo antoyo mentioned this pull request Dec 18, 2023
Open
antoyo
antoyo reviewed Dec 18, 2023
View reviewed changes
build_system/src/config.rs Show resolved Hide resolved
build_system/src/config.rs Outdated Show resolved Hide resolved
build_system/src/config.rs Show resolved Hide resolved
antoyo
antoyo reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more stuff. Only one file that I still need to review.

build_system/src/utils.rs Outdated Show resolved Hide resolved
build_system/src/utils.rs Outdated Show resolved Hide resolved
@antoyo
Copy link
Contributor

antoyo commented Dec 19, 2023

Some issues with the tests:

  • --mini-tests, --std-tests:
    • Before: it showed the output of the executables ran.
    • After: it is not shown.
    • Please make it so that we see the output.
  • --extended-rand-tests, --extended-regex-example-tests, --extended-regex-tests: The CI task for libgccjit 12 should be removed since it is skipped (I know it ran before this PR, but it's easy to remove in gcc12.yml).

antoyo
antoyo reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about half-way through the last file to review.

build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
antoyo
antoyo reviewed Dec 19, 2023
View reviewed changes
build_system/src/test.rs Outdated Show resolved Hide resolved
antoyo
antoyo reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, we can merge after this.

build_system/src/test.rs Outdated Show resolved Hide resolved
build_system/src/test.rs Show resolved Hide resolved
build_system/src/test.rs Outdated Show resolved Hide resolved
antoyo
antoyo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thanks a lot!

@antoyo antoyo merged commit e0c4d65 into rust-lang:master Dec 19, 2023
32 checks passed
@GuillaumeGomez GuillaumeGomez deleted the rustify-test branch December 19, 2023 22:07
@antoyo antoyo mentioned this pull request Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @antoyo