-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal types missing for some embedded targets #3615
Comments
I would suggest to go for the PR :) |
Hello, are you still planning on PRing this into libc? Otherwise I want to take a crack at it |
I'm fine with you doing it, thanks! |
you initially linked cygwin-newlib implementation. Please keep in mind that esp's uses its own fork of newlib. So if you want to cross reference what is there and what not have a look here . If i understand correctly it should cover both newlib functions found in esp rom and the once that get compiled into the binary (for functions not present in the ROM). |
I'm just getting started with embedded programming, and found that compiling the standard library using rust-analyzer with
-Zbuild-std
fails because of this line.I'm not entirely sure, but it seems like this is entirely valid code, and that the problem lies with
libc
missing definitions forSIGABRT
(and other signal handler #defines).As far as I can tell, these are defined in
newlib
'ssys/signal.h
header, so perhaps the solution could be as simple as adding these tolibc
'snewlib
module? I can put up a PR if you think that's the way to go?My target triple is
riscv32imc-esp-espidf
.This would resolve the following issues:
esp-rs/esp-idf-svc#366
rust-lang/rust-analyzer#16552
The text was updated successfully, but these errors were encountered: