Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow 0.15.0 docs.rs failure #806

Closed
xd009642 opened this issue Jun 3, 2020 · 4 comments
Closed

tensorflow 0.15.0 docs.rs failure #806

xd009642 opened this issue Jun 3, 2020 · 4 comments
Labels
C-build-failure Category: This is a crate that failed to build

Comments

@xd009642
Copy link

xd009642 commented Jun 3, 2020

https://docs.rs/crate/tensorflow/0.15.0
https://docs.rs/crate/tensorflow/0.15.0/builds

So tensorflow doesn't have a way to get the prebuilt C runtime other than downloading it (as far as I know) so it failed to build the most recent release. I was just wondering if there was a feasible way of relaxing that restriction i.e. a size limitation for downloads?

Disclaimer: I'm not a project maintainer just a user but I didn't see any issues raised

@xd009642 xd009642 added the C-build-failure Category: This is a crate that failed to build label Jun 3, 2020
@jyn514
Copy link
Member

jyn514 commented Jun 3, 2020

The network blocking isn't because of concerns about resource usage, but for security reasons. I am not comfortable removing those restrictions for any crate.

As a workaround, maybe the rust project could include tensor flow as a submodules and build it from source? Or if that takes too long, check the binary into git directly (maybe using a submodule to reduce download times)?

@jyn514
Copy link
Member

jyn514 commented Jun 3, 2020

If we ever implemented #315, that would work as well.

@Nemo157
Copy link
Member

Nemo157 commented Jun 3, 2020

It may be useful to raise an issue for the tensorflow project to see if they can just not require the binary to build documentation. As an example the discord_game_sdk is not allowed to distribute the binary they link against and require you to manually download it, yet they still have docs on docs.rs by using an internal feature to skip attempting to link against the binary and just expose the bare minimum so the documentation can be generated.

@xd009642
Copy link
Author

xd009642 commented Jun 3, 2020

tensorflow is a rather large bazel build with numerous dependencies so it'll probably exceed memory and build time limits. I've raised an issue with the project page for the bindings so we'll see what they say but I think all suggestions mentioned would work.

I'll close this as there's nothing to do here, thanks for the help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build-failure Category: This is a crate that failed to build
Projects
None yet
Development

No branches or pull requests

3 participants