Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc version in build image #1741

Closed
ppodolsky opened this issue May 30, 2022 · 4 comments
Closed

Update protoc version in build image #1741

ppodolsky opened this issue May 30, 2022 · 4 comments

Comments

@ppodolsky
Copy link

Crate name

summa

Build failure link

https://docs.rs/crate/summa/0.7.1/builds/567648

Additional details

Hi guys!
I use prost-build to build proto files in build.rs and in its turn it uses system proto compiler. There are some fileds in my proto files that marked as optional. The optional has been added in proto 3.12 and stabilized in 3.15. So it seems that build machines/images contains outdated protoc

@syphar
Copy link
Member

syphar commented May 30, 2022

@ppodolsky the image being used is defined in https://github.com/rust-lang/crates-build-env , see also https://docs.rs/about/builds#missing-dependencies .

Any package in ubuntu focal can be added, so you can just create a PR to the repo.

( I'll review and deploy then)

@syphar
Copy link
Member

syphar commented May 30, 2022

( looking at https://github.com/rust-lang/crates-build-env/blob/master/linux/packages.txt it looks like we only have libprotoc17 in there currently)

@ppodolsky
Copy link
Author

Yep, as usual I've found these pages immediately after had posted questions here :)

Looks like there is no an easy way because even 22.04 has too outdated protoc. The hackery way is to delete protoc binary before build and it will lead to building of vendored protoc in prost-build crate. But it is such a waste of resources and against the good sense.

@syphar
Copy link
Member

syphar commented May 30, 2022

until we have #315 your options are probably vendoring (as you stated), or conditional compilation if you don't need protoc for the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants