Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the API Guidelines to 1.0 #4

Open
KodrAus opened this issue Mar 9, 2018 · 5 comments
Open

Polish the API Guidelines to 1.0 #4

KodrAus opened this issue Mar 9, 2018 · 5 comments
Labels
resource Related to a resource as opposed to source tracking issue

Comments

@KodrAus
Copy link
Collaborator

KodrAus commented Mar 9, 2018

This is a tracking issue for polishing the API Guidelines as a stable resource. We might want to close this in favour of an issue on the Guidelines repository.

What do we need to do before we can call the API Guidelines '1.0'? How do we want to curate the discussion around guidelines going forward?

@KodrAus
Copy link
Collaborator Author

KodrAus commented Mar 9, 2018

cc @aturon @dtolnay

@aturon
Copy link
Collaborator

aturon commented Mar 9, 2018

AFAIK the actual content is ready to go, and what needs to happen next is for it to become a part of the official "Rust Bookshelf".

@steveklabnik, how does that work?

@QuietMisdreavus
Copy link

The basic process for getting something onto the Bookshelf and into official docs is something like this:

  • Open a PR to rust-lang/rust that adds the new docs to the repo:
    • Adds a new submodule for the book
    • Adds rules to rustbuild to allow it to be built with the rest of the docs
    • (Does linkchecker/tidy run automatically? If not, they may need to be pointed at the new output)
    • Add a line to the docs landing page linking to the new book
  • Nominate/FCP it to the docs team for merging

At least, that's basically how it worked for Rust By Example. At that point, i'd probably want to make sure we have some kind of subteam set up for its maintenance, since my understanding would be that it would come under the docs team's purview at that point.

@KodrAus
Copy link
Collaborator Author

KodrAus commented Mar 29, 2018

Thanks @QuietMisdreavus!

I'm also interested to know what we want to do with the ongoing discussions, outside of the content itself.

@ghost
Copy link

ghost commented Apr 2, 2018

Having API Guidelines is very good situation.
Having tool which detects API Guidelines invalidations and shows example from the guadline (more or like clippy does) is even much better.
I know the compiler warns about a few of them (like camelcase).
Wouldn't this feature be expanded?

@KodrAus KodrAus added resource Related to a resource as opposed to source tracking issue labels Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resource Related to a resource as opposed to source tracking issue
Projects
None yet
Development

No branches or pull requests

3 participants