modifiedWriteValues ignored in patches

[kossnikita]

#106 added support for modifiedWriteValues but this ignored in patches

  SCR:
    _modify:
      IOSB0:
        access: write-only
        modifiedWriteValues: oneToClear

            <field>
              <name>IOSB0</name>
              <description>Set bit 0</description>
              <bitOffset>0</bitOffset>
              <bitWidth>1</bitWidth>
              <access>write-only</access> << it works
            </field>

[burrbull]

https://github.com/stm32-rs/stm32-rs/blob/da9085da570e8934b205115f128500c27ca721fb/peripherals/flash/flash_v1.yaml#L8-L10

[kossnikita]

Yes, I do it like in this example. Why doesn't this patch work? Doesn't this provide an advantage when used with svd2rust?

[burrbull]

How looks your patch? Have you added _W1C?

[kossnikita]

Oh. Thank you. This is not at all the behavior I expected.

    RLDF:
      _read:
        NotReached: [0, "Downcounter doesn't reached 0x40"]
        Reached: [1, "Downcounter reached 0x40"]
      _W0C:
        Clear: [0, "Clear flag"]

<modifiedWriteValues>zeroToClear</modifiedWriteValues>
<enumeratedValues>
  <name>RLDFR</name>
  <usage>read</usage>
  <enumeratedValue>
    <name>NotReached</name>
    <description>Downcounter doesn't reached 0x40</description>
    <value>0</value>
  </enumeratedValue>
  <enumeratedValue>
    <name>Reached</name>
    <description>Downcounter reached 0x40</description>
    <value>1</value>
  </enumeratedValue>
</enumeratedValues>
<enumeratedValues>
  <name>RLDFW</name>
  <usage>write</usage>
  <enumeratedValue>
    <name>Clear</name>
    <description>Clear flag</description>
    <value>0</value>
  </enumeratedValue>
</enumeratedValues>

[burrbull]

oneToClear is _W1C. Not _W0C

[kossnikita]

I get it. In this case, I need W0C.

[burrbull]

Can we close this, or there still an issue?

[kossnikita]

I'm not sure. On the one hand, there is a functionality implements this. By the way, it's undocumented #5 . On the other hand, this behavior seems unintuitive.
I would like to add the possibility of such a patch as in my original example.

[burrbull]

I would like to add the possibility of such a patch as in my original example.

Reasonable. Could you make PR?