Optional finalizers in kotlin #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Sep 12, 2024
| {%- else %} | ||
| @Override | ||
| @SuppressWarnings("Finalize") | ||
| fun finalize() { |
There was a problem hiding this comment.
wait kotlin used to let you just tack on a finalize method? i did not expect it to be that old school.
no wonder it's deprecated.
There was a problem hiding this comment.
yeah, i think the warning is because it's deprecated now -- you can do the same thing in Java
There was a problem hiding this comment.
Yeah, I'm familiar with the Java thing I had just almost completely memoryholed it because it's like, something I remember from when I first encountered Java as a kid.
So it was a bit of a throwback seeing this :)
Manishearth
reviewed
Sep 12, 2024
Manishearth
approved these changes
Sep 12, 2024
|
cc @jcrist1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an option (specifiable via the Kotlin configuration file) to allow users to specify that they want to generate
finalizermethods to clean up pointers to opaque data, instead of using Cleaners.This is useful to support older version of the JVM API.