Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Serde Traits? #13

Open
holtgrewe opened this issue Sep 1, 2020 · 3 comments
Open

Implementing Serde Traits? #13

holtgrewe opened this issue Sep 1, 2020 · 3 comments

Comments

@holtgrewe
Copy link

Would it make sense to implement serde traits?

@pmarks
Copy link
Contributor

pmarks commented Sep 1, 2020

yes - definitely. Some types already do (https://github.com/rust-bio/rust-bio-types/blob/master/src/alignment.rs#L18).

We should expose them via a feature flag so that people who don't need serde aren't forced to have it.

@holtgrewe
Copy link
Author

@pmarks thanks, cf. #14 splits out serde support into a feature (that is by default not enabled)

@holtgrewe
Copy link
Author

I'm really uncertain whether there should be separate tests for the serde feature... I added running tests with all features enabled, though, which means that the create is compiled with and without serde support, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants