Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SyntaxKind with Into<SyntaxKind> in function parameters #145

Open
spencerwhite opened this issue Nov 20, 2022 · 0 comments
Open

Replace SyntaxKind with Into<SyntaxKind> in function parameters #145

spencerwhite opened this issue Nov 20, 2022 · 0 comments

Comments

@spencerwhite
Copy link

It would be much more convenient to write builder.start_node(Ast::Expr) than builder.start_node(Ast::Expr.into()), assuming there is an impl From<Ast> for SyntaxKind somewhere. Obviously not a huge deal, but it would slightly cut down on boilerplate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spencerwhite