Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Grist] Domain not recognized with default config #3087

Open
3 tasks done
DennisGaida opened this issue Apr 8, 2024 · 4 comments
Open
3 tasks done

🐛 [Grist] Domain not recognized with default config #3087

DennisGaida opened this issue Apr 8, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@DennisGaida
Copy link

Store Application

Grist

App version

1.12

Description

Default installation of Grist does not ask for any additional config / settings upon installation, but both the local as well as the direct (host:port) connections don't work with the following error message:

{"error":"Domain not recognized: grist.example.com"}

Whereas example.com is just my configured local domain. I suppose some initial configuration is missing for Grist to get running.

Steps to reproduce

  1. Install Grist
  2. Try to open Grist with the local domain (usually grist.tipi.local) or the host:port direct connection
  3. Observe error

App logs

Logs look fine as-in there is no error to be observed.

I see in the logs the info: == defaultBaseDomain: with the internal server IP set to "defaultBaseDomain". I suppose this needs to be *not* the server IP when you are accessing it via FQDN.

Browser

No response

Browser logs

No response

User-Config changes

No response

Other

No response

Please confirm the following

  • I believe this issue is a bug that affects all users of RunTipi, not something specific to my installation.
  • I have already searched for relevant existing issues and discussions before opening this report.
  • I have updated the title field above with a concise description.
@DennisGaida DennisGaida added the bug Something isn't working label Apr 8, 2024
@DennisGaida
Copy link
Author

DennisGaida commented Apr 8, 2024

Some further investigation:

app.env contains APP_DOMAIN=<ip> instead of the FQDN. I checked other apps and they all have APP_DOMAIN=FQDN instead. Looking at https://github.com/runtipi/runtipi-appstore/blob/master/apps/grist/docker-compose.yml I see the APP_HOME_URL env var correctly set. Checking the app.env I don't see the APP_HOME_URL set at all, so don't know what's going on here.

The environment variable GRIST_SANDBOX_FLAVOR is set correctly for the app.

I did reinstall as well with no change. APP_DOMAIN & APP_HOST remain the IP of the server instead of the FQDN.

@meienberger
Copy link
Collaborator

meienberger commented Apr 24, 2024

Hello @DennisGaida the APP_DOMAIN is set to the ip in order to allow you to access the app through IP:PORT. Does this work correctly? With today's capabilities it's not possible to make this app work with a local domain since Grist only allow one origin... We will release a new update that will allow you to granularly select which option you want to enable (ip:port, local_domain, public_domain)

@DennisGaida
Copy link
Author

I blocked all direct IP access for security reasons, hence I didn't test that. But I suppose this just works™️, since that is what is configured.

APP_DOMAIN corresponds to the set domain name or local domain (not sure now), but that can be set in RT - APP_DOMAIN is not configured to be the internal IP in any of the other apps I tried, I deem this to be a bug in this app.
I understand the limitation of Grist only allowing one endpoint - that endpoint shouldn't be the IP is what I am saying.

@meienberger
Copy link
Collaborator

I understand your issue, and this is not a bug in the app config but a limitation of how tipi generates the env variables. You can test other apps, if you don't check the expose option during install, APP_DOMAIN will always be IP:PORT, if you check it it will be the given domain. This is not an issue for most apps but is for a few like Grist where you need to explicitly give it the trusted origin (we are fixing this as we speak)

The APP_HOME_URL variable is constructed like this:

- APP_HOME_URL=${APP_PROTOCOL:-http}://${APP_DOMAIN}

While waiting for the next release, you can still apply a custom config to your app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants