Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to intitial nix setup #35

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Followup to intitial nix setup #35

merged 6 commits into from
Sep 10, 2024

Conversation

goodlyrottenapple
Copy link
Contributor

cleaning up a few details, namely:

  • fix update version script to update the nix flake automatically too
  • cleanup the import structure of the nix flake
  • remove redundant overrides for poetry2nix packages

@goodlyrottenapple goodlyrottenapple marked this pull request as ready for review September 8, 2024 14:34
- name: 'Update Nix flake inputs'
run: |
PYKWASM_VERSION=v"$(cat deps/kwasm_release)"
sed -i 's! wasm-semantics.url = "github:runtimeverification/wasm-semantics/v[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+"! wasm-semantics.url = "github:runtimeverification/wasm-semantics/'"${PYKWASM_VERSION}"'"!' flake.nix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the + chars need to be escaped here?

Copy link
Contributor Author

@goodlyrottenapple goodlyrottenapple Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question... I simply copied the code from one of the other repositories. See:

https://github.com/search?q=org%3Aruntimeverification%20%5B%5B%3Adigit%3A%5D%5D%5C%2B%5C.&type=code

@rv-jenkins rv-jenkins merged commit 1f6576b into master Sep 10, 2024
3 checks passed
@rv-jenkins rv-jenkins deleted the sam/nix-cleanup branch September 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants